added some error handling

TASKS.md

@@ -2,34 +2,35 @@
 
 ## 1. Critical Issues
 
-- [ ] **1.1 Fix missing `del` import in store/index.js**
+- [x] **1.1 Fix missing `del` import in store/index.js** ✅ COMPLETE
-  - Line 3 imports `get, set` from idb-keyval but `del` is used on line 13
+  - Line 3 now imports `get, set, del` from idb-keyval
-  - Add `del` to the import statement
+  - Used in removeItem function on line 13
-  - This will cause a ReferenceError when removeItem is called
+  - No more ReferenceError
 
-- [ ] **1.2 Fix hydration flag initialization**
+- [x] **1.2 Fix hydration flag initialization** ✅ COMPLETE
-  - The `onRehydrateStorage` callback uses `store.setState()` before `store` is fully initialized
+  - Implemented Option A: Initialize `_hydrated: true` by default
-  - Creates a circular reference issue preventing app from loading
+  - Removed problematic `onRehydrateStorage` callback
-  - **Options:**
+  - App now loads immediately without hanging on "loading..."
-    - A) Initialize `_hydrated: true` by default (simplest)
+  - Persistence happens in background automatically
-    - B) Use Zustand's persist middleware built-in hydration detection
-    - C) Move hydration callback outside store creation
 
-- [ ] **1.3 Consolidate duplicate storage implementation**
+- [x] **1.3 Consolidate duplicate storage implementation** ✅ COMPLETE
-  - Storage is defined in both `store/index.js` AND `store/middleware/persistence.js`
+  - Single storage implementation in `store/index.js`
-  - The middleware file exports `idbStorage` but it's not being used
+  - Uses idb-keyval directly with createJSONStorage
-  - **Decision needed:** Use one or the other, not both
+  - Clean, simple approach without extra middleware files
 
 ## 2. Architectural Improvements
 
-- [ ] **2.1 Add error handling**
+- [x] **2.1 Add error handling** ✅ COMPLETE
-  - Add try/catch blocks around IndexedDB operations
+  - Added try/catch blocks around all IndexedDB operations (getItem, setItem, removeItem)
-  - Implement fallback if IndexedDB fails or is unavailable
+  - Implemented fallback: returns null on getItem error, silently fails on setItem/removeItem
-  - Add user feedback for errors (toast notifications?)
+  - Added error state to store with auto-clear after 3 seconds
+  - Added validation in addItem and removeItem actions
+  - Created error-toast component with slide-in animation
+  - Toast shows error messages and allows manual dismissal
 
-- [ ] **2.2 Add partialize option to persist middleware**
+- [x] **2.2 Add partialize option to persist middleware** ✅ COMPLETE
-  - Currently saves ALL state including `_hydrated` flag and `route`
+  - Added partialize to exclude `_hydrated` flag from persistence
-  - Should use `partialize: (state) => ({ user: state.user, items: state.items })`
+  - Only persists: user, items, and route
   - Prevents unnecessary data in IndexedDB
 
 - [ ] **2.3 Add basic CSS reset to index.html**

components/app-root.js

@@ -4,6 +4,7 @@ import { StoreController } from "../controllers/store-controller.js";
 import "./nav-bar.js";
 import "./page-home.js";
 import "./page-items.js";
+import "./error-toast.js";
 
 class AppRoot extends LitElement {
     #hydrated = new StoreController(this, store, s => s._hydrated);
@@ -31,6 +32,7 @@ class AppRoot extends LitElement {
         return html`
             <nav-bar .user=${this.#user.value}></nav-bar>
             <main>${this.#renderRoute()}</main>
+            <error-toast></error-toast>
         `;
     }
 

components/error-toast.js

@@ -0,0 +1,79 @@
+// components/error-toast.js
+import { LitElement, html, css } from 'lit'
+import { store } from '../store/index.js'
+import { StoreController } from '../controllers/store-controller.js'
+
+class ErrorToast extends LitElement {
+  #error = new StoreController(this, store, s => s.error)
+
+  static styles = css`
+    :host {
+      position: fixed;
+      top: 1rem;
+      right: 1rem;
+      z-index: 1000;
+    }
+
+    .toast {
+      background: #ef4444;
+      color: white;
+      padding: 1rem 1.5rem;
+      border-radius: 8px;
+      box-shadow: 0 4px 6px rgba(0, 0, 0, 0.1);
+      display: flex;
+      align-items: center;
+      gap: 1rem;
+      min-width: 300px;
+      animation: slideIn 0.3s ease-out;
+    }
+
+    @keyframes slideIn {
+      from {
+        transform: translateX(400px);
+        opacity: 0;
+      }
+      to {
+        transform: translateX(0);
+        opacity: 1;
+      }
+    }
+
+    .message {
+      flex: 1;
+      font-size: 0.9rem;
+    }
+
+    .close {
+      background: none;
+      border: none;
+      color: white;
+      cursor: pointer;
+      font-size: 1.2rem;
+      padding: 0;
+      opacity: 0.8;
+    }
+
+    .close:hover {
+      opacity: 1;
+    }
+  `
+
+  render() {
+    if (!this.#error.value) {
+      return html``
+    }
+
+    return html`
+      <div class="toast">
+        <span class="message">${this.#error.value}</span>
+        <button 
+          class="close" 
+          @click=${() => store.getState().clearError()}
+          aria-label="Close"
+        >×</button>
+      </div>
+    `
+  }
+}
+
+customElements.define('error-toast', ErrorToast)

store/index.js

@@ -2,17 +2,32 @@ import { createStore } from 'zustand/vanilla'
 import { persist, createJSONStorage } from 'zustand/middleware'
 import { get, set, del } from 'idb-keyval'
 
-// Create IndexedDB storage adapter
+// Create IndexedDB storage adapter with error handling
 const storage = createJSONStorage(() => ({
   getItem: async (name) => {
+    try {
       const value = await get(name)
       return value ?? null
+    } catch (error) {
+      console.error('IndexedDB getItem error:', error)
+      return null // Fallback to null if IndexedDB fails
+    }
   },
   setItem: async (name, value) => {
+    try {
       await set(name, value)
+    } catch (error) {
+      console.error('IndexedDB setItem error:', error)
+      // Silently fail - app continues to work without persistence
+    }
   },
   removeItem: async (name) => {
+    try {
       await del(name)
+    } catch (error) {
+      console.error('IndexedDB removeItem error:', error)
+      // Silently fail
+    }
   },
 }))
 
@@ -23,12 +38,40 @@ export const store = createStore(
       user: null,
       items: [],
       route: 'home',
+      error: null,  // For error notifications
       
       // Actions
       setUser: (user) => set({ user }),
-      addItem: (item) => set(s => ({ items: [...s.items, item] })),
+      
-      removeItem: (id) => set(s => ({ items: s.items.filter(i => i.id !== id) })),
+      addItem: (item) => {
+        try {
+          if (!item || !item.name || !item.name.trim()) {
+            throw new Error('Item name is required')
+          }
+          set(s => ({ items: [...s.items, item], error: null }))
+        } catch (error) {
+          console.error('addItem error:', error)
+          set({ error: error.message })
+          setTimeout(() => set({ error: null }), 3000) // Clear after 3s
+        }
+      },
+      
+      removeItem: (id) => {
+        try {
+          if (!id) {
+            throw new Error('Item ID is required')
+          }
+          set(s => ({ items: s.items.filter(i => i.id !== id), error: null }))
+        } catch (error) {
+          console.error('removeItem error:', error)
+          set({ error: error.message })
+          setTimeout(() => set({ error: null }), 3000)
+        }
+      },
+      
       navigate: (route) => set({ route }),
+      
+      clearError: () => set({ error: null }),
     }),
     {
       name: 'app-store',